Fixed Draft in a series causing confusion with members

[nicodak]

If a draft is assigned to a series, the title of the draft appears as the last article in the series (
if he is) and the click redirects to the classic XF error page. The draft article is also counted in the number of articles in the series.

It is confusing for the user.

You might not assign a draft to a series, but it's still useful for organizing your drafts if you're preparing a lot.

 

[Bob]

If a draft is assigned to a series

Ya, that should not be happening. Articles that are in a non visible state (draft, awaiting, moderated or deleted) are not allowed to be added to a series, so I've added some additional validation checks to the Add Series Part Service as well as some additional checks to all of the permissions checks functions related to adding an Article to a Series, to prevent articles that are not in the state "visible" from being added to a series.

Example of one of the new validation checks added today. If you try to set an article by URL, the validator will now check the state of the article and throw an error that explains to the viewing user that only visible state articles can be added to a series and that the article that they are attempting to add to a series is in a state other than visible (and displays the current state of the article, which the 5 states are "Visible", "Draft", "Awaiting", "Moderated" and "Deleted".

 

[Bob]

Along with this, I've created a new Job (XenAddons\AMS\Job:SeriesPart) that when run, will remove any Articles that are not visible that are associated with a Series (using the SeriesPart Deleter Service).

This Job will be triggered as part of the AMS 2.2.20 Upgrade via Post Upgrade processes:

        if ($previousVersion && $previousVersion < 2022070)
        {
            $this->app->jobManager()->enqueueUnique(
                'xa_amsUpgradeSeriesPartRebuild',
                'XenAddons\AMS:SeriesPart',
                [],
                false
            );
        }

This Job will also be triggered once every 24 hours by the AMS Daily Clean-up CRON.

    public static function runDailyCleanUp()
    {
        $app = \XF::app();

        /** @var \XenAddons\AMS\Repository\Article $artilceRepo */
        $artilceRepo = $app->repository('XenAddons\AMS:Article');
        $artilceRepo->pruneArticleReadLogs();
        $artilceRepo->autoUnfeatureArticles();
       
        $app->jobManager()->enqueueUnique(
            'xa_amsDailyCleanUpSeriesPartRebuild',
            'XenAddons\AMS:SeriesPart',
            [],
            false
        );
    }

This Job can also be processed manually via cache rebuilds >> AMS: Rebuild series parts.