Fixed Convert post to update sets item last updated to current date and time

[benFF]

Showcase Version

3.2.33

XenForo Version

2.2.15

PHP Version

8

Database & Version

MariaDB 10.3

Are there any errors being throw?

No

When I convert a post to an update I would expect the main item's "updated date" to be changed to the date of the converted post (if later than currently set date)

However, it currently sets it to the present date and time.

I went though some items/threads yesterday from over 10 years ago converting all the updates, but now Showcase lists them all as freshly updated :s

 

[Bob]

Just so you know, It has nothing to do with the Convert Post to Update function. The Convert Post to Update function does NOT have any code that sets the Item last_update field to TIMENOW.

It's the ItemUpdate Entity's postSave() behavior itself (specifically the updateMadeVisible() function as part of the postSave() process) that is doing that.

I've added some additional code to the updateMadeVisible() function that will determine whether to set the Item last_update date.

This now covers scenarios like moderating/deleting an update and then later approving or undeleting, as it won't set the Items last update date to TIMENOW and would only ever set it if the update_date was newer than the items last_update date.

 

[benFF]

Thanks for this - I'll hold off my next batch of conversions until this release drops

 

[Bob]

@benFF I just pushed out a maintenance release with this bug fix, can you please test this out ASAP and let me know if its working correctly for you?

 

[Bob]

@benFF I just pushed out a maintenance release with this bug fix, can you please test this out ASAP and let me know if its working correctly for you?

No need... a couple license holders already contacted me saying that this is working perfectly now for them.