Recent Daily error reports

[Regs]

For the last month or so, I've been getting the following ACP server error log reports:

Server Error Log
Error Info
ErrorException: Argument 1 passed to NFLJ_Pickem_Model_Picks::getCurrentPlayerPicks() must be of the type array, null given, called in /home/takethep/public_html/library/NFLJ/Pickem/ControllerPublic/Pickem.php on line 607 and defined - library/NFLJ/Pickem/Model/Picks.php:13
Generated By: Unknown Account, Tuesday at 7:27 PM
Stack Trace
#0 /home/takethep/public_html/library/NFLJ/Pickem/Model/Picks.php(13): XenForo_Application::handlePhpError(4096, 'Argument 1 pass...', '/home/takethep/...', 13, Array)
#1 /home/takethep/public_html/library/NFLJ/Pickem/ControllerPublic/Pickem.php(607): NFLJ_Pickem_Model_Picks->getCurrentPlayerPicks(NULL, 8332)
#2 /home/takethep/public_html/library/XenForo/FrontController.php(351): NFLJ_Pickem_ControllerPublic_Pickem->actionPlayerPicks()
#3 /home/takethep/public_html/library/XenForo/FrontController.php(134): XenForo_FrontController->dispatch(Object(XenForo_RouteMatch))
#4 /home/takethep/public_html/index.php(13): XenForo_FrontController->run()
#5 {main}
Request State
array(3) {
  ["url"] => string(100) "http://www.takethepiss.com/pickem/vmsl-premier-2015-16-pickem-challenge.10/player-picks?user_id=8332"
  ["_GET"] => array(1) {
    ["user_id"] => string(4) "8332"
  }
  ["_POST"] => array(0) {
  }
}

and

Server Error Log
Error Info
ErrorException: Undefined index: pickem_pool_id - library/XenForo/Visitor.php:678
Generated By: Unknown Account, Tuesday at 7:27 PM
Stack Trace
#0 /home/takethep/public_html/library/XenForo/Visitor.php(678): XenForo_Application::handlePhpError(8, 'Undefined index...', '/home/takethep/...', 678, Array)
#1 /home/takethep/public_html/library/NFLJ/Pickem/ControllerPublic/Pickem.php(604): XenForo_Visitor->offsetGet('pickem_pool_id')
#2 /home/takethep/public_html/library/XenForo/FrontController.php(351): NFLJ_Pickem_ControllerPublic_Pickem->actionPlayerPicks()
#3 /home/takethep/public_html/library/XenForo/FrontController.php(134): XenForo_FrontController->dispatch(Object(XenForo_RouteMatch))
#4 /home/takethep/public_html/index.php(13): XenForo_FrontController->run()
#5 {main}
Request State
array(3) {
  ["url"] => string(100) "http://www.takethepiss.com/pickem/vmsl-premier-2015-16-pickem-challenge.10/player-picks?user_id=8332"
  ["_GET"] => array(1) {
    ["user_id"] => string(4) "8332"
  }
  ["_POST"] => array(0) {
  }
}

 

[Bob]

user 8332. Can you tell me if that user recently had any action done eg, merged into another user account maybe? If possible, can I get DB access to check the pickem tables to see if anything is "off" about that particular user_id ?

 

[Regs]

No recent action done to that user.

I have a pair of other same type of errors for a different user as well (there were more but I cleared out the error logs).

I will send you BD access shortly, thanks.

 

[Bob]

Have you done anything like delete any POOLS? One thing that COULD be happening is that a user had a particular pool set as their default and if that pool was deleted, then that user would not have a default pool set and if they booked marked that link, it COULD throw that error. I just modified that method so that it would throw a 404 error instead.

 

[Regs]

I haven't deleted any pools.

I thought I maybe changed permissions but I just checked and nope, all users have access to view (usergroup permissions) and all individual pools allow all usergroups to enter.

 

[Regs]

If needed, you have an admin account on my site - no rush on this of course!

 

[Bob]

There is more to this than user group permissions. Only users IN a pool can do things like check the method being envoked in the error. If someone is attempting to direct access that method and they are not in that pool and don't have a default pool set, its going to throw an error. I've modified the method slightly now so that it throws a more friendly error (404) and it won't log it as an error in the ACP.

Generated By: Unknown Account, Tuesday at 7:27 PM

This means that a GUEST is attempting to view data in a POOL. Probably someone that has something BOOKMARKED and is trying to view player picks when not logged in.

My advice would be to disable 'View Pickem" to the "Unregistered/Unconfirmed" user group as guests can't view anything in pickem anyway.

 

[Regs]

OK, I've disabled unregistered group view permissions for both this and survivor.

Thanks for the help.

 

[Bob]

Im going to make some changes in the next MAJOR version that will allow viewing by Non Pool Members (to include guests). This will be a PER POOL option (so that you can have PRIVATE Pools.