Fixed Division By Zero Error

[gemma]

Edit: Sorry @Bob, just saw you had a ticket system now

Getting a "Division By Zero" error when trying to add a "Would you recommend this item?" selection to an editor review

Spoiler: Server Log Error in full

• DivisionByZeroError: Division by zero
• src/addons/XenAddons/RMS/Entity/Item.php:1925
• Generated by: Janey
• Thu Dec 7, 2023 at 23:14:59

Stack trace​

#0 src/addons/XenAddons/RMS/Service/Review/Preparer.php(179): XenAddons\RMS\Entity\Item->rebuildReviewWouldRecommendDataForItem()
#1 src/addons/XenAddons/RMS/Service/Review/Edit.php(276): XenAddons\RMS\Service\Review\Preparer->afterUpdate()
#2 src/XF/Service/ValidateAndSavableTrait.php(42): XenAddons\RMS\Service\Review\Edit->_save()
#3 src/addons/XenAddons/RMS/Pub/Controller/Review.php(137): XenAddons\RMS\Service\Review\Edit->save()
#4 src/XF/Mvc/Dispatcher.php(352): XenAddons\RMS\Pub\Controller\Review->actionEdit(Object(XF\Mvc\ParameterBag))
#5 src/XF/Mvc/Dispatcher.php(259): XF\Mvc\Dispatcher->dispatchClass('XenAddons\\RMS:R...', 'Edit', Object(XF\Mvc\RouteMatch), Object(XenAddons\RMS\Pub\Controller\Review), NULL)
#6 src/XF/Mvc/Dispatcher.php(115): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XenAddons\RMS\Pub\Controller\Review), NULL)
#7 src/XF/Mvc/Dispatcher.php(57): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#8 src/XF/App.php(2487): XF\Mvc\Dispatcher->run()
#9 src/XF.php(524): XF\App->run()
#10 index.php(20): XF::runApp('XF\\Pub\\App')
#11 {main}

Request state​

array(4) {
["url"] => string(57) "/xxxxxxxxxxx"
["referrer"] => string(82) "xxxxxxxxxxxxx"
["_GET"] => array(0) {
}
["_POST"] => array(15) {
["_xfToken"] => string(8) "********"
["_xfInlineEdit"] => string(1) "1"
["rating"] => string(1) "5"
["title"] => string(0) ""
["pros"] => array(4) {
[0] => string(53) "Available in different thicknesses to suit your needs"
[1] => string(47) "Extremely high quality product for added safety"
[2] => string(13) "Does not slip"
[3] => string(0) ""
}
["cons"] => array(3) {
[0] => string(9) "High cost"
[1] => string(55) "Not easy to use when wearing heals (but no mats are...)"
[2] => string(0) ""
}
["message_html"] => string(580) "<p>This really is a top class product.</p><p><br></p><p>The mattresses are made of high-quality materials and have passed strict quality and durability tests. The underside of the mattress is made of non-slip material so that it stays well in place. The mattresses are foldable and easy to put aside and use. Available in different colors.</p><p><br></p><p><strong>PRODUCT QUALITY</strong> - 10.0/10</p><p><br></p><p><strong>EASE OF INSTALL</strong> - 10.0/10</p><p><br></p><p><strong>SAFETY DURING USE</strong> - 10.0/10</p><p><br></p><p><strong>VERSATILITY</strong> - 9.5/10</p>"
["attachment_hash"] => string(32) "8c79aab12458406279d007c7d7256fd6"
["attachment_hash_combined"] => string(89) "{"type":"rms_review","context":{"review_id":3},"hash":"8c79aab12458406279d007c7d7256fd6"}"
["would_recommend"] => string(3) "yes"
["silent"] => string(1) "1"
["clear_edit"] => string(1) "1"
["_xfRequestUri"] => string(57) "xxxxxxxxxxxx"
["_xfWithData"] => string(1) "1"
["_xfResponseType"] => string(4) "json"
}
}

 

[Bob]

I THINK this was already reported and fixed in RMS 2.2.11/12. I'll keep this open until I can confirm it tho Thank you for reporting!

 

[Bob]

I THINK this was already reported and fixed in RMS 2.2.11/12. I'll keep this open until I can confirm it tho Thank you for reporting!

Yes, already reported and fixed in RMS 2.2.12 Alpha.