Future Fix Pagination breaks if there are non-visible blog entries

[Kirby]

UBS Version

2.3.8

XenForo Version

2.3.6

PHP Version

8.3.20

Database & Version

MariaDB 10.11.11

Are there any errors being throw?

No

Steps to reproduce
On a fresh install

1. Set permission View deleted blog entries to Yes for usergroup Moderating
2. Set category permission View deleted blog entries in category Example category to No for usergroup Moderating
3. Create a new public blog
4. Create 21 public blog entries in category Example Category
5. Soft-Delete the newest 20 blog entries
6. View blogs home as a moderator (eg. user that is a member of Moderating)

Expected Result
One page with one blog entry is shown

Actual Result
A message "There are no blog entries available to view" is displayed, but the pagination shows 2 pages - when going to the second page one blog entry is displayed.



Suggested Fix
Don't show non-visible blog entries when viewing blogs home (this issue might affect more places)
or
(Overfetch entries and) Retry if displayed count < perpage and there are still more entries available (might become pretty inefficient if there are a lot of non-visible blog entries and not be possible everywhere)
or
Set finder conditions to only query blog entries with state != visible that are actually viewable by the visitor (Preferred)

 

[Bob]

Ya, same well known bug as both XFRM and XFMG have (and maybe threads). Its related to IGNORE bug that also messes up pagination (the same fix would generally apply to both bugs).

Marking this as Future Fix (same as the other reported pagination related bug).

 

[Kirby]

Ya, same well known bug as both XFRM and XFMG have (and maybe threads).

Yes, this also affects XFMG (not sure about XFRM, we don't use that), but which well-known bug are you referring to?

I couldn't find an existing one so I posted a new one today:

Pagination breaks if there are non-visible media items

Steps to reproduce On a fresh install Set permission View deleted media tiems to Yes for usergroup Moderating Set category permission View deleted media items in category Example category to No for usergroup Moderating Create 25 media items in category Example Category Soft-Delete the newest 24...

xenforo.com

Its related to IGNORE bug that also messes up pagination (the same fix would generally apply to both bugs).

Hmm, I guess I also don't know this bug
Do you have a link for that?

 

[Bob]

Yes, this also affects XFMG (not sure about XFRM, we don't use that), but which well-known bug are you referring to?

I couldn't find an existing one so I posted a new one today:

Pagination breaks if there are non-visible media items

Steps to reproduce On a fresh install Set permission View deleted media tiems to Yes for usergroup Moderating Set category permission View deleted media items in category Example category to No for usergroup Moderating Create 25 media items in category Example Category Soft-Delete the newest 24...

xenforo.com

Hmm, I guess I also don't know this bug
Do you have a link for that?

When you ignore someone like AndyB that sometimes dominates the Index Page of the Resource Manager, you end up with an empty page 1 as every single resource is by someone one you ignored. It happens because the way XF developers designed it is that ignored users are removed AFTER the fetch. Its an annoying bug that has been in XFRM (and XFMG and XF) since 2.0. It only happens when you have an ignored user that is very active, but it does happen.

Ignoring AndyB when he is actively updating his addons (like after a new release) and you will see a blank page 1, half empty page 2, half empty page 3 etc. XF developers are well aware of it.

 

[Bob]

not sure about XFRM

I just tested it again... the bug still exists within XFRM as well.

but which well-known bug are you referring to?

I don't think the bug report got copied over from the XF2 Preview site to xenforo.com. The important part is that XF Developers are aware of it, confirmed it, and have it logged internally Don't ask me how I remember things like this way back in the XF2 Preview days lol

On the other hand, I do chat with XF developers quite a bit and it could be something that was discussed in a Conversation/DM/Group Chat etc...

Anyway, I do agree that it needs resolved, just letting XF take the lead and will apply their standardized solution when available