Custom Phrases not being used

the phrase: nflj_showcase_submitted_a_new_showcase_item has nothing to do with discussion threads.

Are you wanting to modify the context of the first post of an automatically created discussion thread?

 

Phrase: nflj_showcase_message_create_item (uses prepared data from a method in the thread model)

PHP:

    /**
     * Prepares the message for the first post of a new showcase discussion thread
     *
     * @param array $item
     *
     * @return string
     */
    public function prepareMessageForFirstPost(array $item)
    {
        $snip = XenForo_Application::get('options')->scMaxMessageSnippetLength;
        $snippet = trim(XenForo_Helper_String::wholeWordTrim($item['message'], $snip));
       
        $message = new XenForo_Phrase('nflj_showcase_message_create_item', array(
            'title' => $item['item_name'],
            'username' => $item['username'],
            'userId' => $item['user_id'],
            'snippet' => $snippet,
            'itemLink' => XenForo_Link::buildPublicLink('canonical:showcase', $item)
        ), false);
       
        return $message;       
    }

Same thing with the UPDATE posts.

Phrase: nflj_showcase_message_update_item

PHP:

    /**
     * Prepares an update message for an existing showcase discussion thread
     *
     * @param array $item
     * @param array $thread
     *
     * @return string
     */
    public function prepareUpdateMessageForPostToThread(array $item, array $thread, $customMessage)
    {
        if ($customMessage)
        {
            $snippet = $customMessage;
        }
        else
        {
            $snip = XenForo_Application::get('options')->scMaxMessageSnippetLength;
            $snippet = trim(XenForo_Helper_String::wholeWordTrim($item['message'], $snip));
        }
       
        $message = new XenForo_Phrase('nflj_showcase_message_update_item', array(
            'title' => $item['item_name'],
            'username' => $item['username'],
            'userId' => $item['user_id'],
            'snippet' => $snippet,
            'itemLink' => XenForo_Link::buildPublicLink('canonical:showcase', $item)
        ), false);
       
        return $message;       
    }