Your username here MUST MATCH your XenForo username (connected to your XF license).

    Once you have registered here, then you need to start a conversation at xenforo.com w/Bob and provide the following:
    1. Your XenForo License Validation Token
    2. The Domain Name associated with the License
    NOTE: Your account will be validated once ALL requirements are verified/met. Thank you for your patience.

Updated Minor code change to NFLJ_Showcase_DataWriter_Item


New Member
AMS Premium
SC Premium
We've written an addon that extends Showcase to allow fractional ratings. This was mostly straightforward, except for a very minor change we needed to make to NFLJ_Showcase_DataWriter_Item that couldn't be accomplished except by copy-pasting an entire method in our addon. We're hoping you'll adopt this change into Showcase, since it marginally improves extensibility and is arguably better style.

The change: in the first SQL query within NFLJ_Showcase_DataWriter_Item::updateRating, replace SUM(rating) with COALESCE(SUM(rating), 0).

That query currently works fine without the COALESCE because XenForo_DataWriter automatically converts null int/uint values to 0. But since we changed rating to a float, that implicit conversion no longer happens and we'd get exceptions on items with no ratings.
Upvote 0
This suggestion has been implemented. Votes are no longer accepted.
Im super busy with XF2 stuff right now, so this will have to wait until I can find time to work on XF1 stuff.