Fixed Featured content bug in Showcase while attempting to move reviews from one item to another item

[joec]

Showcase Version

3.3.6

XenForo Version

2.3.6

PHP Version

8.3.19

Database & Version

MySQL 8.0.31

Are there any errors being throw?

Yes

Hi Bob,

We discovered a bug in Showcase today. It relates to moving reviews. Here's the stack trace:

```
XF\Db\Exception: MySQL statement prepare error [1146]: Table 'xenforo.xf_xa_sc_item_feature' doesn't exist src/XF/Db/AbstractStatement.php:230


SELECT COUNT(*)
FROM xf_xa_sc_item_feature AS feature
INNER JOIN xf_xa_sc_item AS item ON (item.item_id = feature.item_id)
WHERE item.category_id = ?
AND item.item_state = 'visible'

------------

#0 src/XF/Db/Mysqli/Statement.php(207): XF\Db\AbstractStatement->getException('MySQL statement...', 1146, '42S02')
#1 src/XF/Db/Mysqli/Statement.php(43): XF\Db\Mysqli\Statement->getException('MySQL statement...', 1146, '42S02')
#2 src/XF/Db/Mysqli/Statement.php(61): XF\Db\Mysqli\Statement->prepare()
#3 src/XF/Db/AbstractAdapter.php(96): XF\Db\Mysqli\Statement->execute()
#4 src/XF/Db/AbstractAdapter.php(152): XF\Db\AbstractAdapter->query('
SELECT COUN...', 260)
#5 src/addons/XenAddons/Showcase/Entity/Category.php(558): XF\Db\AbstractAdapter->fetchOne('
SELECT COUN...', 260)
#6 src/addons/XenAddons/Showcase/Service/Review/Mover.php(164): XenAddons\Showcase\Entity\Category->rebuildCounters()
#7 src/addons/XenAddons/Showcase/Service/Review/Mover.php(128): XenAddons\Showcase\Service\Review\Mover->updateTargetData()
#8 src/addons/XenAddons/Showcase/InlineMod/Rating/Move.php(34): XenAddons\Showcase\Service\Review\Mover->move(Array)
#9 src/XF/InlineMod/AbstractAction.php(161): XenAddons\Showcase\InlineMod\Rating\Move->applyInternal(Object(XF\Mvc\Entity\ArrayCollection), Array)
#10 src/XF/Pub/Controller/InlineModController.php(133): XF\InlineMod\AbstractAction->apply(Object(XF\Mvc\Entity\ArrayCollection), Array)
#11 src/XF/Mvc/Dispatcher.php(362): XF\Pub\Controller\InlineModController->actionPerform(Object(XF\Mvc\ParameterBag))
#12 src/XF/Mvc/Dispatcher.php(264): XF\Mvc\Dispatcher->dispatchClass('XF\\Pub\\Controll...', 'Perform', Object(XF\Mvc\RouteMatch), Object(XF\Pub\Controller\InlineModController), Object(XF\Mvc\Reply\Reroute))
#13 src/XF/Mvc/Dispatcher.php(121): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XF\Pub\Controller\InlineModController), Object(XF\Mvc\Reply\Reroute))
#14 src/XF/Mvc/Dispatcher.php(63): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#15 src/XF/App.php(2826): XF\Mvc\Dispatcher->run()
#16 src/XF.php(806): XF\App->run()
#17 index.php(23): XF::runApp('XF\\Pub\\App')
#18 {main}
```

Thanks for taking a look!

 

[Bob]

Thank you for reporting this @joec

This has been resolved in SC 3.3.7 (forgot to update the rebuildCounters() function in the Category Entity).

Sorry about that!

Will push out SC 3.3.7 asap (this week) .

 

[Kirby]

Note sure if this is already fixed as well, but the non-existing table is also referenced in Item::_postDelete() which causes errors when deleting items.