Fixed Account Details: "Articles author name" and "About article author" inputs are hidden when user reaches their max articles per user count.

[Bob]

AMS Version

AMS 2.3.11 and older

XenForo Version

XF 2.3

PHP Version

N/A

Database & Version

N/A

Are there any errors being throw?

No

As per title, if you set the permission "Max articles per user" and the user reaches that Max amount, the Account Details inputs for "Articles author name" and "About article author" are hidden due to the aggressive nature of the permissions check canAddAmsArticle() in the XF User Entity being called by the TM to determine whether to display the inputs or not.

I've changed the TM to no longer call the aggressive canAddAmsArticle() function and instead only check to see if the user has the AMS Article permission Create articles via $xf.visitor.hasAmsArticlePermission('add')

This makes the inputs available even IF the user has reached their Max articles count.