Xenforo 1.3

[blatchy]

Trying sportsbook out on 1.3 and am getting this error when editing a category

An exception occurred: Argument 1 passed to XenForo_ViewAdmin_Helper_Style::getStylesAsSelectList()

 

[blatchy]

1. XenForo_Application::handlePhpError() in XenForo/ViewAdmin/Helper/Style.php at line 9
2. XenForo_ViewAdmin_Helper_Style::getStylesAsSelectList() in NFLJ/Sportsbook/ViewAdmin/Category/Edit.php at line 7
3. NFLJ_Sportsbook_ViewAdmin_Category_Edit->renderHtml() in XenForo/ViewRenderer/Abstract.php at line 227
4. XenForo_ViewRenderer_Abstract->renderViewObject() in XenForo/ViewRenderer/HtmlAdmin.php at line 78
5. XenForo_ViewRenderer_HtmlAdmin->renderView() in XenForo/FrontController.php at line 582
6. XenForo_FrontController->renderView() in XenForo/FrontController.php at line 158
7. XenForo_FrontController->run() in /home/thedude/public_html/admin.php at line 13

 

[Bob]

hmmm nothing has changed in core xf for this. Do you get the same error when trying to edit a Node?

 

[blatchy]

I just went and dumped the tables from the "old" db and imported them in..

 

[blatchy]

this was the server error..

ErrorException: Undefined index: styles - library/NFLJ/Sportsbook/ViewAdmin/Category/Edit.php:7

 

[Bob]

I can't reproduce it... I am running xf 1.3.0 Beta 1 and Sportsbook 1.3.0 Beta 2.

Just for a test, I just installed xf 1.2.4 and sportsbook 1.2.0. I upgraded sportsbook to 1.3.0 Beta 2, edited a category and it saved just fine. I then upgraded to xf 1.3.0 Beta 1 and edited a category and it saved just fine. I was able to choose different styles and they rendered just fine.

Can you walk me through STEP by STEP what you did (just like I did above with the exact versions).

 

[blatchy]

out of curiousity how did you get beta 2? I have been waiting for that to fix the media bbcode issue

 

[Bob]

the Beta 2 I mentioned is Sportsbook.

Step 1. I installed XenForo 1.2.4
Step 2. I installed Sportsbook 1.2.0
Step 3. I upgraded Sportsbook from 1.2.0 to 1.3.0 Beta 2 (which is the latest version of sportsbook that I released)
Step 4. I upgraded XenForo from 1.2.4 to 1.3.0 Beta 1

 

[blatchy]

sorry dude.. its late here

Misread.

 

[Bob]

no worries.. late here as well (1:15 AM). I am trying to reproduce it, but I can't.

 

[blatchy]

yeah I am in same time zone..

its not a big deal. its not as if my categories are going to change any

 

[Bob]

Well, if its an issue, we need to fix it Just cause I can't reproduce it on my environments, doesn't mean there isn't an issue. I use the same exact core xenforo code as the Nodes tho (the exact syntax), so if there is an issue saving a sportsbook category, there will be the same exact issue when you try and edit a NODE/FORUM

 

[blatchy]

Well not sure what the issue was.

I followed the instructions to upgrade to the beta version. Reuploaded the files and the problems went away.

 

[blatchy]

Now that I am poking around I have a bit of a style issue

 

[Bob]

the same modifications that your style made to the core XF Filter classes will have to also be applied to any addon that also uses those same classes.

 

[Bob]

btw, the css used for that is core xf discussion_list.css Sportsbook does nothing to modify that at all. its 100% core XF.

 

[blatchy]

just interesting that it showed up just fine before with the old version and now the beta doesnt show properly.

 

[Bob]

not sure what you mean. The Filter system is new in Sportsbook 1.3.0 Beta 2. The old version of sportsbook had tabs on the right hand side but they were not part of the core XF filter system.

 

[blatchy]

yeah you are right.. I was thinking of the tabs.

I looked in the discussion_list.css but am not sure what I am looking for to fix it.

 

[Bob]

Its towards the bottom of the CSS file. Its even labled "filters". You should use firefox with firebug as you can see exactly what classes are involved and what elements those classes are using

/** filters **/
       
.discussionListFilters
{
    font-size: 11px;
    overflow: hidden; zoom: 1;
}

    .discussionListFilters .filtersHeading
    {
        float: left;
        margin-right: 5px;
        color: @primaryLight;
        font-weight: bold;
    }
   
    .discussionListFilters .removeFilter,
    .discussionListFilters .removeAllFilters
    {
        color: @primaryMedium;
        background: @primaryLighterStill url('@imagePath/xenforo/gradients/form-button-white-25px.png') repeat-x top;
        border: 1px solid @primaryLighterStill;
        border-radius: 5px;
        padding: 2px 10px;
    }
   
        .discussionListFilters .gadget
        {
            color: @primaryLight;
            font-weight: bold;
            margin-left: 3px;
        }

   
        .discussionListFilters .removeFilter:hover,
        .discussionListFilters .removeAllFilters:hover
        {
            background-color: @primaryLightest;
            text-decoration: none;
            color: @mutedTextColor;
            box-shadow: 1px 1px 5px rgba(0,0,0, 0.15);
        }
       
    .discussionListFilters .pairsInline dt
    {
        display: none;
    }
   
    .discussionListFilters .filterPairs
    {
        float: left;
    }
   
    .discussionListFilters .removeAll
    {
        float: right;
    }
   
        .discussionListFilters .removeAllFilters
        {
            padding: 2px 6px;
        }