Fixed External purchase url can be set regardless of category settings

[Painbaker]

XenForo Version String: XenForo 2.2.13

Addon Version String: CAS 2.2.28


Steps to reproduce:
1) Enable "Allow an external purchase url to be set when posting or editing ads" for category
2) Open ad adding/editing page, set external purhase URL
3) Disable external purchase urls in category
4) Save ad

setExternalPurchaseUrl($this->filter('external_purchase_url', 'str'));

Probably should be wrapped in a

if ($ad.canSetExternalPurchaseUrl()) {}

condition

 

[Bob]

Fair enough, altho extremely edge case

setupAddItem:

        if ($ad->canSetExternalPurchaseUrl())
        {
            $adder->setExternalPurchaseUrl($this->filter('external_purchase_url', 'str'));
        }

setupAdEdit:

        if ($ad->canSetExternalPurchaseUrl())
        {
            $editor->setExternalPurchaseUrl($this->filter('external_purchase_url', 'str'));
        }

setupAdCreate:

        if ($category->canSetExternalPurchaseUrl())
        {
            $creator->setExternalPurchaseUrl($this->filter('external_purchase_url', 'str'));
        }

setupItemEdit:

        if ($item->canSetExternalPurchaseUrl())
        {
            $editor->setExternalPurchaseUrl($this->filter('external_purchase_url', 'str'));
        }