Fixed Default category: Location bug

[DragonByte Tech]

RMS Version

2.3.6

XenForo Version

2.3.13

PHP Version

8.3.33

Database & Version

11.4.13-MariaDB

Are there any errors being throw?

No

By default, a fresh install adds a category with allow_location = 0 but require_location = 1. When checking the category flag, only require_location is checked:

            if (
                !$item->location
                && $this->category->require_location
            )
            {
                $errors[] = \XF::phraseDeferred('xa_rms_please_set_location');
            }

While it's unlikely someone would just push the system live with no alternations, and saving the category with no changes does correct the require_location flag, probably warrants a correction

 

[Bob]

By default, a fresh install adds a category with allow_location = 0 but require_location = 1.

Nice catch! updated the installer to set both to 0.

Also updated both the create service and edit service validation functions to include checking to see if location is allowed for the category as well! Another nice catch. You need to give your AI a performance bonus