Fixed article variable in Showcase addon

[egerci]

Hello,

there is a error src/addons/XenAddons/Showcase/Pub/Controller/Item.php line 504

return $this->redirect($this->buildLink('showcase', $article));

I think "article" variable name should be replaced with "item" variable name. I guess this bug/error existed in previous versions.

XenForo Version String: XenForo 2.2.3 Patch 1

Addon Version String: Showcase 3.2.5

ErrorException: [E_NOTICE] Undefined variable: article src/addons/XenAddons/Showcase/Pub/Controller/Item.php:504
Oluşturan: Bilinmeyen Hesap 22 Şubat 2021 16:25

#0 src/addons/XenAddons/Showcase/Pub/Controller/Item.php(504): XF::handlePhpError(8, '[E_NOTICE] Unde...', 's...', 504, Array)
#1 src/XF/Mvc/Dispatcher.php(350): XenAddons\Showcase\Pub\Controller\Item->actionReviews(Object(XF\Mvc\ParameterBag))
#2 src/XF/Mvc/Dispatcher.php(257): XF\Mvc\Dispatcher->dispatchClass('XenAddons\\Showc...', 'Reviews', Object(XF\Mvc\RouteMatch), Object(XenAddons\Showcase\Pub\Controller\Item), NULL)
#3 src/XF/Mvc/Dispatcher.php(113): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XenAddons\Showcase\Pub\Controller\Item), NULL)
#4 src/XF/Mvc/Dispatcher.php(55): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#5 src/XF/App.php(2326): XF\Mvc\Dispatcher->run()
#6 src/XF.php(488): XF\App->run()
#7 index.php(20): XF::runApp('XF\\Pub\\App')
#8 {main}

 

[Bob]

I think "article" variable name should be replaced with "item" variable name.

That is correct and has been fixed in SC 3.2.6 (thank you for reporting).

I guess this bug/error existed in previous versions.

Yes, its been there for awhile now, thankfully its in a low level feature (filtering reviews), so not causing major issues.