Resolved AMS Server error 2.2 Beta

[Brad P]

Hi Bob,

Can you help me on the server error below, is it something you can help me with.

Server error log
ErrorException: [E_WARNING] Declaration of XenAddons\AMS\FindNew\Article::filterResults(XF\Mvc\Entity\ArrayCollection $results) should be compatible with XF\FindNew\AbstractHandler::filterResults(XF\Mvc\Entity\AbstractCollection $results) src/addons/XenAddons/AMS/FindNew/Article.php:8
Generated by: Brad P Aug 26, 2020 at 11:31 AM
Stack trace
#0 src/addons/XenAddons/AMS/FindNew/Article.php(8): XF::handlePhpError(2, '[E_WARNING] Dec...', '/home/allbhhrc/...', 8, Array)
#1 src/vendor/composer/ClassLoader.php(444): include('/home/allbhhrc/...')
#2 src/vendor/composer/ClassLoader.php(322): Composer\Autoload\includeFile('/home/allbhhrc/...')
#3 [internal function]: Composer\Autoload\ClassLoader->loadClass('XenAddons\\AMS\\F...')
#4 [internal function]: spl_autoload_call('XenAddons\\AMS\\F...')
#5 src/XF/Repository/FindNew.php(72): class_exists('XenAddons\\AMS\\F...')
#6 src/XF/ControllerPlugin/FindNew.php(87): XF\Repository\FindNew->getFindNewHandler('ams_article')
#7 src/XF/Pub/Controller/AbstractWhatsNewFindType.php(20): XF\ControllerPlugin\FindNew->getFindNewHandler('ams_article')
#8 src/XF/Mvc/Dispatcher.php(350): XF\Pub\Controller\AbstractWhatsNewFindType->actionIndex(Object(XF\Mvc\ParameterBag))
#9 src/XF/Mvc/Dispatcher.php(257): XF\Mvc\Dispatcher->dispatchClass('XenAddons\\AMS:W...', 'Index', Object(XF\Mvc\RouteMatch), Object(XenAddons\AMS\Pub\Controller\WhatsNewArticle), NULL)
#10 src/XF/Mvc/Dispatcher.php(113): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(XenAddons\AMS\Pub\Controller\WhatsNewArticle), NULL)
#11 src/XF/Mvc/Dispatcher.php(55): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#12 src/XF/App.php(2298): XF\Mvc\Dispatcher->run()
#13 src/XF.php(464): XF\App->run()
#14 index.php(20): XF::runApp('XF\\Pub\\App')
#15 {main}
Request state
array(4) {
  ["url"] => string(31) "/whats-new/ams-articles/?skip=1"
  ["referrer"] => string(23) "https://chatbanter.com/"
  ["_GET"] => array(1) {
    ["skip"] => string(1) "1"
  }
  ["_POST"] => array(0) {
  }
}
Delete

 

[Bob]

The issue is caused by a method signature change in the FindNew AbstractHandler (from using ArrayCollection to AbstractCollection): XF 2.2 - XF\FindNew\AbstractHandler->filterResults BC break - 2.2 Beta 4

The BC (Backwards Compatibility) break (which was just released yesterday in XF 2.2.0 Beta 4) has already been addressed in the upcoming AMS 2.2.0 Beta 2 release. This effects any addon that implements FindNew handlers for content types (and all of my addons beta 2 versions already handle it).

 

[Brad P]

The issue is caused by a method signature change in the FindNew AbstractHandler (from using ArrayCollection to AbstractCollection): XF 2.2 - XF\FindNew\AbstractHandler->filterResults BC break - 2.2 Beta 4

The BC (Backwards Compatibility) break (which was just released yesterday in XF 2.2.0 Beta 4) has already been addressed in the upcoming AMS 2.2.0 Beta 2 release. This effects any addon that implements FindNew handlers for content types (and all of my addons beta 2 versions already handle it).

Awesome thank you.

 

[Bob]

Awesome thank you.

Just released AMS 2.2.0 Beta 2 (as well as Sportsbook 2.2.0 Beta 2), which both addons fix the BC break with XF 2.2.0 Beta 4.

 

[Brad P]

Perfect, working