• REGISTRATION REQUIREMENTS:

    Your username here MUST MATCH your XenForo username (connected to your XF license).

    Once you have registered here, then you need to start a conversation at xenforo.com w/Bob and provide the following:
    1. Your XenForo License Validation Token
    2. The Domain Name associated with the License
    NOTE: Your account will be validated once ALL requirements are verified/met. Thank you for your patience.

Fixed Comments are loaded unconditionally

Kirby

Member
AMS Premium
CAS Premium
IMS Premium
LD Premium
RMS Premium
SC Premium
UBS Premium
LD Version
2.3.9 and older
XenForo Version
2.3.6
PHP Version
N/A
Database & Version
N/A
Are there any errors being throw?
No
As far as I can see, item comments are loaded unconditionally for actionView.

This seems to be a bit inefficient, especially if there is a significant amount of items which don't have comments at all (like it is the case for us) .

Ideally comments should only be loaded if the visitor has permission to view comments and there are visible comments (e.g comment_count > 0), the visitor has appropriate moderating permissions or the visitor posted a pending comment within the session.
 
I've made a few adjustments in the upcoming release (LD 2.3.10) that should cover all the bases now. We can always make further adjustments if need be.

Fixed this for Recent Reviews and Recent Questions as well :)
 
Back
Top