Fixed Template error messages on Item Create/Edit (xf 1.2)

After upgrading to xf 1.2.0, there are 3 template errors thrown when on the create item or edit item pages. These are due to changes in the attachment_editor template in core XF that I need to replicate in the nflj_showcase_attachment_editor template.

I've made the changes and the template errors go away, however, I've not had time to do any deep testing to see if there are any ill effects yet.

These errors do not prevent you from creating or editing an item, they are just eye sore.

 

For anyone that wants to upgrade to xf 1.2.0 beta 1, you will need to replace 1 template.

edit template: nflj_showcase_attachment_editor_attachment

replace entire contents with this:

HTML:

<xen:require css="nflj_showcase_attachment_editor.css" />
 
<li id="{xen:if $isTemplate, 'AttachedFileTemplate', 'attachment{$attachment.attachment_id}'}"
    class="AttachedFile {xen:if '{$attachment} and {$attachment.thumbnailUrl}', 'AttachedImage'} secondaryContent">
 
    <div class="Thumbnail">
        <xen:if is="{$attachment} and{$attachment.thumbnailUrl}">
            <a href="{xen:link attachments, $attachment}" target="_blank"
                data-attachmentId="{$attachment.attachment_id}"
                class="_not_LbTrigger" data-href="{xen:link misc/lightbox}"><img
                src="{$attachment.thumbnailUrl}" alt="{$attachment.filename}"
                class="_not_LbImage" data-src="{xen:link attachments, $attachment, 'embedded=1'}" /></a>
        <xen:else />
            <span class="genericAttachment"></span>
        </xen:if>
    </div>
 
    <div class="AttachmentText">
        <div class="Filename"><a href="{xen:link attachments, $attachment}" target="_blank">{xen:if $attachment, $attachment.filename, ''}</a></div>
       
        <xen:if is="{$isTemplate}">
            <input type="button" value="{xen:phrase cancel}" class="button smallButton AttachmentCanceller" />
           
            <span class="ProgressMeter"><span class="ProgressGraphic">&nbsp;</span><span class="ProgressCounter">0%</span></span>
        <xen:else />
            <noscript>
                <a href="{xen:link 'showcase-attachments/delete', $attachment}" target="_blank" class="button Smallbutton">{xen:phrase delete}</a>
            </noscript>
           
            <xen:if is="{$attachment.thumbnailUrl}">
                <div class="label">{xen:phrase nflj_showcase_showcase_image_gallery}</div>
            </xen:if>
           
            <div class="controls">               
                <input type="button" value="{xen:phrase delete}" class="button smallButton AttachmentDeleter" data-href="{xen:link 'showcase-attachments/delete', $attachment}" />
            </div>
        </xen:if>
 
    </div>
   
</li>