1. REGISTRATION REQUIREMENTS:

    Register with your xenforo.com Username then start a conversation at xenforo.com w/Bob and provide the following:
    1. Your XenForo License Validation Token
    2. The Domain Name associated with the License
    NOTE: Your account will be validated once ALL requirements are verified/met. Thank you for your patience.

Fixed gallery.js image path error

Discussion in 'Showcase Resolved Bug Reports' started by MagnusB, Sep 28, 2013.

  1. MagnusB

    MagnusB Member Showcase

    Just discovered this on my site, and seems to be the same on yours. In gallery.js, there is this:
    Code:
    Gallery = (function() {
            var current    = 0,
                mode = 'carousel', // mode : carousel || fullview
                anim = false,
                init = function() {
    
                    $items.add('<img src="images/ajax-loader.gif"/><img src="images/black.png"/>').imagesLoaded( function() {
                        _addViewModes();
                        _addImageWrapper();
                        _showImage( $items.eq( current ) );
                    });
    
    This ajax-loader.gif and blank.png will point to http://www.domain.com/images/ajax-loader.gif and same for black.png. I change it to point to styles/default/nflj/showcase/slider/, which removed the error. Not a biggie though, doesn't seem to break any functionality.
     
    MattW likes this.
  2. MattW

    MattW Server Admin AMS Premium CAS Premium RMS Premium SC Premium UBS Premium

    Noticed this myself just now while having a look at my page speed results. This does slow the page render down slightly, as it's waiting for them before loading the next element

    upload_2013-10-14_4-28-44.png
     
  3. MagnusB

    MagnusB Member Showcase

    Come to think of it, you don't really need ajax-loader.gif, as you already have a bx_loader.gif. It might make sense to use the same loader animation for both of these scripts (though their behaviour is different, gallery loads it via js, meaning you will have to use the default directory, while bx slider loads it via css I think, so it respects @imagePath).
     
  4. Bob

    Bob Developer Staff Member

    I've modified the path on line 46 to use the default showcase directory. I'll probably also minify this (altho, its a really small file to begin with).
     
  1. This site uses cookies to help personalise content, tailor your experience and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.